-
Notifications
You must be signed in to change notification settings - Fork 24
Дроздов Глеб, М3335 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://task-5-git-fork-drozdikgleb-master.itmo-yandex.now.sh |
src/app/components/header/Header.tsx
Outdated
| const now = moment(); | ||
|
|
||
| export class Header extends React.Component<IProps> { | ||
| public state: IState; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
state не должен быть public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Его на самом деле надо просто выше указать
class Header extends React.Component<IProps, IState>
| @@ -0,0 +1,16 @@ | |||
| .search-box { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут бы тоже не помешало затемнение
| @@ -0,0 +1,4 @@ | |||
| .DateRangePicker { | |||
| top: -2px; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А затемнения нет)
| } | ||
|
|
||
| export class MessagesBox extends React.Component<IProps> { | ||
| public state: IState; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут тоже самое <IProps, IState>
| this.props.openMessage(messageData.text); | ||
| } | ||
| }} | ||
| style={messageData.display ? {} : { display: 'none' , height: '0px' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лучше унести в класс
Выполнены задания 1, 2.1(тёмная тема), 3.2(календарь)